Re: [SCM] GNU Autoconf source repository branch, master, updated. v2.65-35-ga2889ee

[Ralf Wildenhues]

Hi Eric, and sorry for the delay,

* Ralf Wildenhues wrote on Sun, Jan 24, 2010 at 03:07:25PM CET:
> * Eric Blake wrote on Sun, Jan 24, 2010 at 02:36:47PM CET:
> > Since it fixes a regression, this deserves a NEWS item.

> Also, the failure didn't show up because we were chickening out on the
> testsuite because of MinGW.  I intend to commit this after testing the
> usual suspects, but I don't know if I'll get to that today.

OK, the deal is this:

Current Cygwin fails the test with or without the patch below, but for
another reason:

+allowed-chars Zardos differ: char 168, line 2

I'm not sure whether it is a regression.  I've tried to debug it; it
looks like an issue in Cygwin sed or the shell.  The config.status
script in that test directory looks weird: the text which is to be
substituted for @zardoz@ is mangled in a way that part of the last line
of the string also appears on an earlier line.  I fail to see any
connection with newline encoding here, however.

MinGW fails the test with the patch, but not without.

DJGPP also fails to substitute CR correctly, and probably for other
reasons to, haven't checked.

Concluding, the NEWS entry would rather have to state something like

  ** The substitution of carriage return into a config file works again
     on more systems.  Regression introduced in 2.63b.

but I'm not sure whether that really is news-worthy.  Should we test CR
on all non-w32 systems at least?

Thanks,
Ralf

>     Add NEWS entry for last commit, re-add testsuite exposure.
>     
>     * NEWS: Update.
>     * tests/torture.at (Substitute and define special characters):
>     Again, try carriage return.
>     Spotted by Eric Blake.
> 
> diff --git a/NEWS b/NEWS
> index 207325e..f802678 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -14,6 +14,9 @@ GNU Autoconf NEWS - User visible changes.
>  ** AC_PROG_INSTALL correctly uses `shtool' again.  Regression introduced
>     in 2.64.
>  
> +** The substitution of carriage return into a config file works again
> +   portably.  Regression introduced in 2.63b.
> +
>  * Major changes in Autoconf 2.65 (2009-11-21) [stable]
>    Released by Eric Blake, based on git versions 2.64.*.
>  
> diff --git a/tests/torture.at b/tests/torture.at
> index 8291694..edc485f 100644
> --- a/tests/torture.at
> +++ b/tests/torture.at
> @@ -876,9 +876,7 @@ baz=bla
>      for j in 0 1 2 3 4 5 6 7; do
>        for k in 0 1 2 3 4 5 6 7; do
>       case $i$j$k in #(
> -     000 | 015 | 377) ;; # MinGW awk dislikes 0xFF, and the test does
> -                         # the wrong thing for CR on MinGW.
> -                         #(
> +     000 | 377) ;; # MinGW awk dislikes 0xFF.
>       *) printf \\$i$j$k's' ;; # The 's' works around a Solaris 8 /bin/bash 
> bug.
>       esac
>        done
>