Re: [PATCH 4/4] Work around DJGPP shell function return bug with command substitutions.

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Ralf Wildenhues on 9/13/2009 1:18 PM:
> DJGPP bash 2.04 has a bug in that `return $ac_retval' done in a
> shell function which also contains a command substitution causes
> the shell to barf.  For more details see
> <http://www.delorie.com/djgpp/mail-archives/browse.cgi?p=djgpp/2006/08/08/16:37:27>.
> Possible workaround include putting the `return' in a subshell
> or calling another function to set the status.

Fix this nit before applying.

>  
> +DJGPP bash 2.04 has a bug in that @command{return} from a shell function
> +which also used a command substitution causes a segmentation fault.
> +Details are not unclear; to work around the issue, you can use

"not unclear" is a double negative.  How about just deleting the initial
clause, and starting the sentence with "To work around"...

> address@hidden from a subshell, or @samp{AS_SET_STATUS} as last command
> +in the execution flow of the function (@pxref{Common Shell Constructs}).
> +
>  Not all shells treat shell functions as simple commands impacted by
>  @samp{set -e}, for example with Solaris 10 @command{bin/sh}:
>  

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkquLgQACgkQ84KuGfSFAYCWwwCeL1CoYmLUOtxe1q31IkxVUWM0
9d8AnR+G/Z02M1R1Q5NQizpd9uuA/XZG
=GHDe
-----END PGP SIGNATURE-----