autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: EUnit failure?


From: Ralf Wildenhues
Subject: Re: EUnit failure?
Date: Sat, 22 Aug 2009 10:51:49 +0200
User-agent: Mutt/1.5.20 (2009-08-09)

* Romain Lenglet wrote on Thu, Aug 20, 2009 at 01:55:29AM CEST:
> Ralf Wildenhues wrote:
> > * Romain Lenglet wrote on Wed, Aug 19, 2009 at 02:37:39PM CEST:
> >> Here is that patch.
> >> I have tested only with Erlang/OTP R13B, but it should also work with R12B.
> > 
> > Sorry, still fails, see below.
> 
> I tested this patch using R12B, from the same Ubuntu package you are
> using, and it now works for me.

You are right.  A "make clean && make check" now worked.

> This suggests that either the patch didn't apply cleanly, or you didn't
> run "make" and "make testsuite" after applying the patch?

Well, the rebuild rules were not including changes to your new Autotest
file.  I looked over the files and guessed that erlang.m4 also needs to
be listed in the AUTOCONF_FILES in tests.

Committing this, and your patch to fix the Erlang test; and removing the
unneeded copying of the install-sh file in the Erlang EUnit test.

Thanks again for working through me with this.

Cheers,
Ralf

        Fix build dependencies for Erlang macro files.
        * lib/freeze.mk (autotest_m4f_dependencies): Add
        $(src_libdir)/autotest/specific.m4.
        * tests/Makefile.am (AUTOCONF_FILES): Add erlang.m4.

diff --git a/lib/freeze.mk b/lib/freeze.mk
index 2237101..45e68e2 100644
--- a/lib/freeze.mk
+++ b/lib/freeze.mk
@@ -74,7 +74,8 @@ m4sh_m4f_dependencies =                               \
 autotest_m4f_dependencies =                    \
        $(m4sh_m4f_dependencies)                \
        $(src_libdir)/autotest/autotest.m4      \
-       $(src_libdir)/autotest/general.m4
+       $(src_libdir)/autotest/general.m4       \
+       $(src_libdir)/autotest/specific.m4
 
 autoconf_m4f_dependencies =                    \
        $(m4sh_m4f_dependencies)                \
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 4c29a6e..085c9d1 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -168,6 +168,7 @@ AUTOCONF_FILES = $(autoconfdir)/general.m4 \
                 $(autoconfdir)/functions.m4 \
                 $(autoconfdir)/lang.m4 \
                 $(autoconfdir)/c.m4 \
+                $(autoconfdir)/erlang.m4 \
                 $(autoconfdir)/fortran.m4 \
                 $(autoconfdir)/headers.m4 \
                 $(autoconfdir)/libs.m4 \




reply via email to

[Prev in Thread] Current Thread [Next in Thread]