|
From: | Paolo Bonzini |
Subject: | Re: new Erlang macros for testing for modules, functions, etc. |
Date: | Fri, 07 Aug 2009 17:49:36 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
On 08/07/2009 03:54 PM, Romain Lenglet wrote:
Hi, Here is a series of patches for 1) fixing the command line used for AC_RUN_IFELSE so that the run fails if the module doesn't compile (patch 0001), and 2) adding 4 new macros to test for modules, functions, and headers (patches 0002-0004) with their doc and tests. I have split the changes into 4 patches, to hopefully make your review easier.
I committed the first.For the others, I'd like to understand from the maintainers what is the plan for 2.64.1/2.65, and in any case I'd rather see it use the language dispatch mechanism (e.g. AC_LANG_PUSH(Erlang) and then use AC_CHECK_FUNC normally, or something like that). But I have not read the patches beyond the changelogs, so the latter remark might be unapplicable or otherwise stupid.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |