autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Simplify handling of autotest tracing


From: Eric Blake
Subject: Re: [PATCH v2] Simplify handling of autotest tracing
Date: Mon, 13 Jul 2009 05:54:45 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.22) Gecko/20090605 Thunderbird/2.0.0.22 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Paolo Bonzini on 7/12/2009 8:56 AM:
>       * lib/autotest/general.m4 (at_fn_check_prepare_notrace): Use
>       $at_trace_echo.  Add new REASON argument.
>       (at_fn_check_prepare_trace): Do not call at_fn_check_prepare_notrace.
>       Use $at_check_filter_trace.
>       (at_fn_check_prepare_dynamic): Use at_fn_check_prepare_notrace.
>       (at_traceon): Initialize to ':'.
>       (at_traceoff): Remove, use 'set -x' instead throughout.

s/-x/+x/ to match the code change.

>       (at_check_filter_trace, at_trace_echo): New shell variables.
>       Initialize them if tracing is requested.
>       (_AT_DECIDE_TRACEABLE): Adjust call to at_fn_check_prepare_notrace.

Looks like this can shave off some size from the testsuite.  Other than
the other nits in this mail, this is ready to commit.

> -AS_FUNCTION_DESCRIBE([at_fn_check_prepare_notrace], [LINE],
> +AS_FUNCTION_DESCRIBE([at_fn_check_prepare_notrace], REASON LINE,

s/REASON LINE/[&]/

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpbIIUACgkQ84KuGfSFAYAyBgCgrmvHLhs9SHHoz8ksfI6U9Lp3
gXEAoJeRLrSLQr7YJuJ7zFqjcTU00X4x
=w3Xo
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]