Re: [SCM] GNU Autoconf source repository branch, master, updated. v2.63b-70-g9c25a39

[Ralf Wildenhues]

* Paolo Bonzini wrote on Sun, Jul 12, 2009 at 01:18:16PM CEST:
> On 07/11/2009 10:11 AM, Ralf Wildenhues wrote:
> >* Eric Blake wrote on Thu, Jul 09, 2009 at 02:25:49PM CEST:
> >>According to Ralf Wildenhues on 7/9/2009 12:19 AM:
> >>>@@ -994,7 +994,8 @@ AT_CHECK([${CONFIG_SHELL-$SHELL} -c 'test -n 
> >>>"${BASH_VERSION+set}]]dnl
> >>>  [[${ZSH_VERSION+set}${TEST_PARALLEL_AUTOTEST+set}"' || exit 77])
> >>>  # The parallel scheduler requires mkfifo and job control to work.
> >>>  AT_CHECK([mkfifo fifo || exit 77])
> >>>-AT_CHECK([${CONFIG_SHELL-$SHELL} -c '(set -m&&  set +m) || exit 77'])
> >>>+AT_CHECK([${CONFIG_SHELL-$SHELL} -c '(set -m&&  set +m) || exit 77'],
> >>>+   [], [], [ignore])
> >>Hmm, shouldn't we also ignore stderr if mkfifo fails?
> >
> >Hmm, probably; but I haven't encountered that issue.  Is it documented
> >unclearly, or implemented wrongly, that an exit status of 77 does not
> >override a mismatched stdout/stderr with AT_CHECK?
> 
> The implementation is correct.  First at_fn_check_status exits if
> the test's exit status 77.  Then at_failed is checked and
> at_fn_log_failure is invoked if it is true, but at this point we
> already exited.

Without my patch and with zsh 4.3.4,
   CONFIG_SHELL=/bin/zsh /bin/zsh ./testsuite -k parallel

leads to a bunch of failures like this:

../../autoconf/tests/autotest.at:1064: ${CONFIG_SHELL-$SHELL} -c 'test -n 
"${BASH_VERSION+set}${ZSH_VERSION+set}${TEST_PARALLEL_AUTOTEST+set}"' || exit 77
Not enabling shell tracing (command contains a ${...} parameter expansion)
../../autoconf/tests/autotest.at:1064: mkfifo fifo || exit 77
../../autoconf/tests/autotest.at:1064: ${CONFIG_SHELL-$SHELL} -c '(set -m && 
set +m) || exit 77'
Not enabling shell tracing (command contains a ${...} parameter expansion)
--- /dev/null   2008-04-28 20:08:22.000000000 +0200
+++ /tmp/autoconf/build/tests/testsuite.dir/at-groups/170/stderr     2009-07-12 
17:05:12.000000000 +0200
@@ -0,0 +1 @@
+set: can't change option: -m
micro-suite.log:
sed: can't read micro-suite.log: No such file or directory
170. autotest.at:1005: 170. parallel test execution (autotest.at:1005): FAILED 
(autotest.at:1064)

With my patch, the parallel tests are all ok (i.e., pass not skip),
except for "parallel syntax error" which is skipped.

So sorry for the mis-analysis; this zsh version warns about 'set -m' but
it has exit status 0, and the tests come out correctly too.  So no, I
don't think the mkfifo needs the same treatment.

Cheers,
Ralf