Re: [PATCH] Fix treatment of --enable-assert in AC_HEADER_ASSERT

[William Pursell]

Paolo Bonzini wrote:
>> Paolo, did you run this through the testsuite?  I ran my version through, 
>> and 
>> noticed a couple of problems: if the user didn't specify 
>> --{en,dis}able-assert, 
>> then the AC_MSG_RESULT prints nothing.  Also, AC_MSG_WARN must be quoted.
> 
> I ran the AC_HEADER_ASSERT test only, to ensure I hadn't screwed up the
> quoting, and it passed.  I assumed Bill did the full run...

The only failure I get is an "unbalanced m4_divert_push", which
I believe is a spurious error coming from other changes in my
source dir.  (Or rather, 'believed'.)  How is it that this
patch causes that error?

I apologize for not doing a proper stash of my changes
and running the test suite on a clean dir, and would
be grateful for a brief explanation of what this error
means in more detail.

testuite.log:

#                             -*- compilation -*-
33. m4sugar.at:249: testing ...
../../autoconf/tests/m4sugar.at:273: autom4te --language=m4sugar script.4s -o 
script -o-
../../autoconf/tests/m4sugar.at:284: autom4te --language=m4sugar script.4s -o 
script -o-
../../autoconf/tests/m4sugar.at:293: autom4te --language=m4sugar script.4s -o 
script -o-
stderr:
script.4s:1: error: too many m4_divert_pop
script.4s:1: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
../../autoconf/tests/m4sugar.at:293: sed 's/^[^:]*m4[.ex]*: *\([^:]*:\) 
*\([0-9][0-9]*: \)/m4:\1\2/
        s/^\([^:]*:\) *\([0-9][0-9]*:\)[^:]*m4[.ex]*: /m4:\1\2 /
        s/: C\(annot open \)\([^`:]*\):/: c\1`\2'\'':/
        s/: include:\( cannot open\)/:\1/
        s/^autom4te: [^ ]*m4[.ex]* /autom4te: m4 /
        s/ (E[A-Z]*)$//
    ' stderr >&2
Not enabling shell tracing (command contains a `...` command substitution)
../../autoconf/tests/m4sugar.at:306: autom4te --language=m4sugar script.4s -o 
script -o-
stderr:
script.4s:3: error: m4_divert_pop(2): diversion mismatch:
script.4s:2: m4_divert_push: 1
script.4s:1: m4_divert: KILL
script.4s:3: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
../../autoconf/tests/m4sugar.at:306: sed 's/^[^:]*m4[.ex]*: *\([^:]*:\) 
*\([0-9][0-9]*: \)/m4:\1\2/
        s/^\([^:]*:\) *\([0-9][0-9]*:\)[^:]*m4[.ex]*: /m4:\1\2 /
        s/: C\(annot open \)\([^`:]*\):/: c\1`\2'\'':/
        s/: include:\( cannot open\)/:\1/
        s/^autom4te: [^ ]*m4[.ex]* /autom4te: m4 /
        s/ (E[A-Z]*)$//
    ' stderr >&2
Not enabling shell tracing (command contains a `...` command substitution)
../../autoconf/tests/m4sugar.at:319: autom4te --language=m4sugar script.4s -o 
script -o-
stderr:
:0: error: m4_init: unbalanced m4_divert_push:
script.4s:3: m4_divert_push: 2
script.4s:2: m4_divert: KILL
:0: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
../../autoconf/tests/m4sugar.at:319: sed 's/^[^:]*m4[.ex]*: *\([^:]*:\) 
*\([0-9][0-9]*: \)/m4:\1\2/
        s/^\([^:]*:\) *\([0-9][0-9]*:\)[^:]*m4[.ex]*: /m4:\1\2 /
        s/: C\(annot open \)\([^`:]*\):/: c\1`\2'\'':/
        s/: include:\( cannot open\)/:\1/
        s/^autom4te: [^ ]*m4[.ex]* /autom4te: m4 /
        s/ (E[A-Z]*)$//
    ' stderr >&2
Not enabling shell tracing (command contains a `...` command substitution)
--- -   2008-12-09 04:22:54.000000000 +0000
+++ 
/Users/williampursell/src/.build-autoconf/tests/testsuite.dir/at-groups/33/stderr
   2008-12-09 04:22:54.000000000 +0000
@@ -1,6 +1,6 @@
-script.4s:2: error: m4_init: unbalanced m4_divert_push:
+:0: error: m4_init: unbalanced m4_divert_push:
 script.4s:3: m4_divert_push: 2
 script.4s:2: m4_divert: KILL
-script.4s:2: the top level
+:0: the top level
 autom4te: m4 failed with exit status: 1

33. m4sugar.at:249: 33. m4_divert_stack (m4sugar.at:249): FAILED 
(m4sugar.at:319)


-- 
William Pursell