[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/12] use a shell function for AC_COMPUTE_INT
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 10/12] use a shell function for AC_COMPUTE_INT |
|
Date: |
Mon, 27 Oct 2008 15:27:50 +0000 (UTC) |
|
User-agent: |
Loom/3.14 (http://gmane.org/) |
Paolo Bonzini <bonzini <at> gnu.org> writes:
>
> Updated patch attached, thanks for the review.
Still one nit, but I think it's ready to apply.
> m4_define([_AC_COMPUTE_INT_RUN],
> [_AC_RUN_IFELSE([AC_LANG_INT_SAVE([$3], [$1])],
> - [$2=`cat conftest.val`], [$4])])
> + [AS_VAR_SET([$2], [`cat conftest.val`]); $4], [$5])
> +rm -f conftest.val
> +])
>
>
> +# _AC_COMPUTE_INT_BODY
...
> + _AC_COMPUTE_INT_RUN([$[]2], [$[]3], [$[]4],
> + [ac_retval=0], [ac_retval=1])
> + fi
> + rm -f conftest.val
Why are we invoking rm twice? The second one is a no-op.
--
Eric Blake