[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/12] use a shell function for _AC_CHECK_HEADER_MONGREL
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH 06/12] use a shell function for _AC_CHECK_HEADER_MONGREL |
Date: |
Sat, 25 Oct 2008 14:57:50 +0200 |
User-agent: |
Thunderbird 2.0.0.17 (Macintosh/20080914) |
> AC_CHECK_HEADERS invokes a shell for loop on
> the variable ac_header, which it then reads after the expansion of
> AC_CHECK_HEADER has executed; but here you are assigning into it
> (fortunately,
> you are reassigning the value it already had). But what's wrong with using
> $[]2 instead of $ac_header?
I was not sure whether we accepted shells that did not save positional
parameters, but we actually don't. I will redo patches 7-12 to apply
the tricks you did (body function, no repeated AS_VAR_PUSHDEF) and not
save arguments into variables.
> Meanwhile, before I actually work on this patch, I noticed a small
> optimization
> that I will be applying soon:
Is this really worth it?...
Paolo