autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] use m4_require to implement AS_REQUIRE


From: Eric Blake
Subject: Re: [PATCH] use m4_require to implement AS_REQUIRE
Date: Fri, 17 Oct 2008 05:27:38 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.17) Gecko/20080914 Thunderbird/2.0.0.17 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Paolo Bonzini on 10/12/2008 10:20 AM:
> The implementation is easy, though I had to try several times before
> getting it right.  Anyway, the attached patch works and adds a testcase
> for the first behavior.  The second bug is already tested by the existing
> AS_REQUIRE_SHELL_FN test, which however needs to be modified in order
> to really test this behavior.

It's still not perfect.  This file is failing:

AS_INIT
foo=bar
AS_VAR_PUSHDEF([tmp], [foo])
AS_VAR_IF(tmp, [bar], [echo yes], [echo no])
AS_VAR_POPDEF([tmp])

because it is expanding _AS_TR_SH_PREPARE in the middle of AS_VAR_IF
rather than hoisting it into M4SH-INIT right after _AS_CR_PREPARE:

eval as_val=\$# Sed expression to map a string onto a valid variable name.
as_tr_sh="eval sed 'y%*+%pp%;s%^_$as_cr_alnum%_%g'"

foo

I'm trying to figure out the correct approach, but it seems like we can't
dump anything into the final diversion until all of the dependency
ordering has been collected into the growth area.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkj4dqoACgkQ84KuGfSFAYCQ9wCfUkSHyfiYmIVfQTvLFB+nFsVV
9sEAoI1e53Ise/EXQa+i2U/k+BtGhOp9
=sQ6V
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]