[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Libtool test failure with current master
From: |
Eric Blake |
Subject: |
Re: Libtool test failure with current master |
Date: |
Thu, 16 Oct 2008 06:02:30 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.17) Gecko/20080914 Thunderbird/2.0.0.17 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Paolo Bonzini on 10/16/2008 12:16 AM:
> Sorry. This was hidden by the sh.test failure -- I did try testing
> Libtool, but it didn't run the Autotest-based testsuite.
>
> I didn't investigate it very much, but this fixes it and is conceptually
> correct: we're expanding stuff in place in _AS_PREPARE, and we're taking
> care of the ordering manually, so it's bad to add stuff in diversions
> other than the one we're working on.
Well, I had already pushed my fix (not using _AS_ECHO_LOG and hence
$LINENO when reporting a broken LINENO implementation), which also made
the libtool test pass. But your patch is also correct whether or not mine
had been applied, so I'm okay with keeping both fixes in the repository as
a way to avoid further latent bugs.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkj3LVYACgkQ84KuGfSFAYB0CQCfVqw+oXEO1b4lVx6jYpbeL2OO
AIIAnRIb+JEtdmNkcR6SprAmJAq51Wjj
=TxqA
-----END PGP SIGNATURE-----