Re: [PATCH] modernize AS_UNSET a bit (take 2)

[Eric Blake]

Eric Blake <ebb9 <at> byu.net> writes:

> > +# For backwards compatibility.
> > +AS_REQUIRE([_AS_UNSET_PREPARE])
> > +
> 
> Is this strictly necessary, considering $as_unset was undocumented?  Any uses 
> in configure.ac are okay (because configure already uses AS_PREPARE), so we 
> only have to worry about independent m4sh scripts.  Hmmm, looking further at 
> libtool's usage patterns - at least libtoolize.m4sh calls
> 
> AS_SHELL_SANITIZE
> $as_unset CDPATH

After thinking about this more, I think _AS_UNSET_PREPARE must be left alone in 
AS_SHELL_SANITIZE, and not moved to AS_INIT.  AS_INIT calls AS_SHELL_SANITIZE 
under the hood (and AS_SHELL_SANITIZE is marked deprecated), but the libtool 
scripts don't use AS_INIT - they went straight to AS_SHELL_SANITIZE.  (Wow, 
libtool's use of undocumented internals is really annoying.)

-- 
Eric Blake