autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Yet another shell function prerequisite!


From: Eric Blake
Subject: Re: [PATCH] Yet another shell function prerequisite!
Date: Mon, 13 Oct 2008 16:54:04 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

Paolo Bonzini <bonzini <at> gnu.org> writes:

> 
> This is a little unfortunate, but I just noticed it and it is a bit
> annoying.  With the shell functions patches I have things like this:
> 
> 
> Notice the repeated occurrences of 874 and 900, which are in the
> ac_func_c_check_header function.  And this could even be worse, since
> LINENO in function might even count lines from the beginning of the
> function (and in general is unportable).  So my current solution is to
> pass $LINENO as an additional argument, and have _AS_ECHO_LOG use
> as_lineno if defined.

Yep - I had a suspicion that we would have to deal with LINENO in shell 
functions sooner or later.

> 
> Any better ideas?  If no, ok?  If yes, now or later?
> -_AS_ECHO([$as_me:$LINENO: $1], [AS_MESSAGE_LOG_FD])])
> +_AS_ECHO([$as_me:${as_lineno:-$LINENO}: $1], [AS_MESSAGE_LOG_FD])])

Now is as good a time as any.  That's actually quite a slick trick, once we 
make sure as_lineno is defined in the correct places.  Please apply.

-- 
Eric Blake







reply via email to

[Prev in Thread] Current Thread [Next in Thread]