[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/5] remove shell function "spy"
From: |
Eric Blake |
Subject: |
Re: [PATCH 4/5] remove shell function "spy" |
Date: |
Wed, 08 Oct 2008 06:29:28 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.17) Gecko/20080914 Thunderbird/2.0.0.17 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Paolo Bonzini on 9/18/2008 8:14 AM:
> This patch removes the shell function "spy" that was added a
> few years ago. It did help finding a couple of bugs, it has
> made its time though.
Agreed. I've applied this one as-is.
We may want to add a future spy for other features (but not in this
patch); on my list:
Do all shells that support functions also support unset (I haven't found a
countercase yet, but my search space is not very broad)? If so, we can
kill _AS_UNSET_PREPARE in a few more releases.
Can we always find a shell with $(( )) support (at least cygwin ash
supports functions, but lacks arithmetic and $LINENO)? For now, I'm
thinking of porting at_func_arith into m4sh.
Can we always find a shell with XSI parameter expansion support
(${foo##*/}) (again, my search space isn't very broad)? It would be nice
to borrow from libtool's func_dirname which avoids forking on decent
shells (with the added benefit of handling trailing newline correctly).
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkjsp6gACgkQ84KuGfSFAYCx2QCfefGW/0aSliiTzLunsq4CGyaU
zQcAoNRixKIYmlKhQfenqW9iThP/hSdb
=Kdit
-----END PGP SIGNATURE-----