[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] avoid duplicate tests for shell functions
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH 2/5] avoid duplicate tests for shell functions |
Date: |
Wed, 08 Oct 2008 08:54:17 +0200 |
User-agent: |
Thunderbird 2.0.0.17 (Macintosh/20080914) |
Eric Blake wrote:
> According to Paolo Bonzini on 9/18/2008 8:13 AM:
>> This one-line patch ensures that if a feature is deemed required,
>> its test is not emitted in the suggested tests. It is not
>> perfect, but it works for the case at hand which is right now
>> the most complex use of the _AS_DETECT_BETTER_SHELL machinery.
>
>> A more complete fix would require more m4fu and time that I
>> have, sorry. :-(
>
> Maybe my m4fu is better?
Definitely, though this is m4sugar-fu.
> How about this patch, instead of yours?
Looks great, please push it. I will then rebase the series and push it
somewhere (including possibly your mob branch, and/or reposting on
autoconf-patches).
Paolo