autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: parallel autotest [2/3]: Implement 'testsuite --jobs'.


From: Ralf Wildenhues
Subject: Re: parallel autotest [2/3]: Implement 'testsuite --jobs'.
Date: Fri, 3 Oct 2008 07:22:59 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

* Ralf Wildenhues wrote on Thu, Oct 02, 2008 at 08:46:24PM CEST:
> 
>    Fix hang with `testsuite -k notmatched'.
> 
>    * lib/autotest/general.m4: Do not reset $at_jobs if it is equal
>    to one.  Fixes hang with `-k notmatched'.

And of course more corner cases of the same kind.  Pushed.

Cheers,
Ralf

    Fix more testsuite hang corner cases.
    
    * lib/autotest/general.m4: Use the serial code path if no test
    is to be run.
    * tests/autotest.at (parallel test execution): Test -j and -jN
    with `-k notmatched'.

diff --git a/lib/autotest/general.m4 b/lib/autotest/general.m4
index be135c1..f1966ce 100644
--- a/lib/autotest/general.m4
+++ b/lib/autotest/general.m4
@@ -1018,6 +1018,9 @@ rm -f "$at_suite_dir/at-source-lines"
 
 # Set number of jobs for `-j'; avoid more jobs than test groups.
 set X $at_groups; shift; address@hidden:@]
+if test $at_max_jobs -eq 0; then
+  at_jobs=1
+fi
 if test $at_jobs -ne 1 &&
    { test $at_jobs -eq 0 || test $at_jobs -gt $at_max_jobs; }; then
   at_jobs=$at_max_jobs
diff --git a/tests/autotest.at b/tests/autotest.at
index a20c4ac..3547ee4 100644
--- a/tests/autotest.at
+++ b/tests/autotest.at
@@ -846,6 +846,9 @@ AT_CHECK([grep -c '^.\{53\}ok' stdout], [], [1
 AT_CHECK([$CONFIG_SHELL ./micro-suite -j3 3], [], [stdout])
 AT_CHECK([grep -c '^.\{53\}ok' stdout], [], [1
 ])
+# Not even with zero tests:
+AT_CHECK([$CONFIG_SHELL ./micro-suite -j -k nomatch], [], [ignore])
+AT_CHECK([$CONFIG_SHELL ./micro-suite -j3 -k nomatch], [], [ignore])
 
 # The parallel scheduler requires mkfifo to work.
 AT_CHECK([mkfifo fifo || exit 77])




reply via email to

[Prev in Thread] Current Thread [Next in Thread]