autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: AC_C_BIGENDIAN answers "universal" on powerpc-aix


From: Eric Blake
Subject: Re: AC_C_BIGENDIAN answers "universal" on powerpc-aix
Date: Fri, 15 Aug 2008 06:14:12 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080708 Thunderbird/2.0.0.16 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Peter O'Gorman on 8/14/2008 11:02 PM:
> It seems likely that someone is already using that define in a progect.
> The macro is meant to be internal to autoconf, why not have it in
> autoconf namespace?

OK.

> 
>>> +#  define WORDS_BIGENDIAN 1
>> Not quite right, since this is for an autoheader template.  In the
>> AH_VERBATIM, it should look like the instance four lines later:
>>
>>> +#  undef WORDS_BIGENDIAN
>> and let config.status do the conversion to the desired state in both
>> locations.
> 
> No, it is correct as is. The compiler, for one invocation will go over
> the sources multiple times, once for each -arch setting.

Yes, I understand that part.  But my point was that autoheader templates
that look like:

#undef WORDS_BIGENDIAN

are transformed to:

#define WORDS_BIGENDIAN 1

by config.status when creating config.h, and that we just added
documentation in the manual stating that the use of:

#define anything

in the autoheader template gives undefined behavior when processed through
config.status.  Seeing as how the non-apple line follows the template
standard of using #undef for the AC_SUBST key, I'm arguing that the
apple-specific line should do so, likewise.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkilcxQACgkQ84KuGfSFAYDrqwCZAZpz10BQwABrBNZ0O8emNEUD
c/4AnjJcfSarX2CID5WUsK6uBm7mcJqM
=9jk1
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]