autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: m4sugar and m4 1.6, bison


From: Eric Blake
Subject: Re: m4sugar and m4 1.6, bison
Date: Wed, 16 Jul 2008 13:59:37 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.14) Gecko/20080421 Thunderbird/2.0.0.14 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Ralf Wildenhues on 7/16/2008 1:11 PM:
| > Should I go ahead and revert my addition of m4_prepend altogether
| Reverting is fine with me.

OK, I'll commit a reversion patch shortly.

|>  m4_define([m4_version_prereq],
|> -[m4_if(m4_version_compare(]m4_dquote(m4_defn([m4_PACKAGE_VERSION]))[,
[$1]),
|> -       [-1],
|> -       [m4_default([$3],
|> -            [m4_fatal([Autoconf version $1 or higher is required],
|> -                      [63])])],
|> -       [$2])])
|> +m4_ifdef([m4_PACKAGE_VERSION],
|> +[[m4_if(m4_version_compare(]m4_dquote(m4_defn([m4_PACKAGE_VERSION]))[,
[$1]),
|
| That's overquoted, no?  How can this work as intended? (untested)

Nope.  It's because it is inside an unquoted m4_ifdef, where the result of
the m4_ifdef must be quoted, so that the overall argument handed to
m4_define is single quoted rather than executed early.  Trust me - I coded
it the wrong way first (one quote instead of two), and did a double take
when bison was still complaining about m4_defn dereferencing undefined
m4_PACKAGE_VERSION.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkh+UykACgkQ84KuGfSFAYCsIQCfQAO99+ZfSw64NjpmxuTo6w4U
1wEAn3uiELyCBb27xxWDiEAI/6LJ2lLX
=Dtxj
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]