[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Properly expand @configure_input@ in config.status.
From: |
Eric Blake |
Subject: |
Re: [PATCH] Properly expand @configure_input@ in config.status. |
Date: |
Tue, 04 Mar 2008 20:08:29 -0700 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12) Gecko/20080213 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Ralf, and finally getting time to look at this series in depth.
According to Ralf Wildenhues on 3/2/2008 4:52 AM:
| * lib/autoconf/status.m4 (_AC_OUTPUT_FILE, _AC_OUTPUT_MAIN_LOOP):
| Escape the backslashes and ampersands in $configure_input before
| using it in the sed replacement string to expand @address@hidden
| Report by Eric Blake and Patrick Welche.
The patch looked okay (and the testsuite improvements proved it).
|
| Signed-off-by: Benoit Sigoure <address@hidden>
| Signed-off-by: Ralf Wildenhues <address@hidden>
| Since this should also fix the test failure Patrick reported, I've
| also listed him as reporter (and Benoit as author).
|
| Was it BTW ok to leave the Signed-off-by's in there?
Yes. In fact, if this were the Linux kernel, you would be required to
leave it in there. As I understand it, a Signed-off-by line implies
authorship (ie. you are signing off on your right to claim/assign
copyright of that patch as appropriate).
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHzg6t84KuGfSFAYARAiwkAKDY+PI6Zd2nWrp1az9EQugzrD3QVwCgylb4
d3i294SE8tmSL/Ojm1Rgx48=
=JI4u
-----END PGP SIGNATURE-----