Re: a couple of bugs

[Ralf Wildenhues]

Hello Benoit,

* Benoit Sigoure wrote on Mon, Dec 17, 2007 at 12:03:36AM CET:
> On Dec 16, 2007, at 11:08 PM, Ralf Wildenhues wrote:
>
>> - FreeBSD: autoupdate hangs on test 172 (AC_LANG_OBJC).  Dunno why  
>> yet,
>>   may be pilot error.

This was a pilot error, after all.

> In an attempt to reproduce this one on FreeBSD 5.5, I stumbled on the  
> following oddity during `gmake all':
>
> [...]
> gmake[1]: Entering directory `/var/tmp/autoconf/man'
> Updating man page autoupdate.1
> PATH="../tests:../build-aux:$PATH"; \
>         export PATH; \
>         /bin/bash /tmp/autoconf/build-aux/missing --run help2man \
>             --include=autoupdate.x \
>             --include=./common.x \
>             --output=autoupdate.1.t `echo 'autoupdate' | sed 's,.*/,,'`
> autoupdate: not found
> help2man: can't get `--help' info from autoupdate
> gmake[1]: *** [autoupdate.1] Error 1
>
> It looks like it's trying to run autoupdate from $PATH (which doesn't  
> exist since it's not installed) instead of the just built autoupdate.

Well, usually the wrappers under ../tests do exist.  However, they don't
if `make check' has not been run yet.

> I sort of tried to hack the Makefile like this:

> --- a/man/Makefile.am
> +++ b/man/Makefile.am
> @@ -54,10 +54,12 @@ SUFFIXES = .x .1
>         @echo "Updating man page $@"
>         PATH="$(top_builddir)/tests$(PATH_SEPARATOR)$(top_srcdir)/ 
> build-aux$(PATH_SEPARATOR)$$PATH"; \
>         export PATH; \
> +       autom4te_perllibdir="$(abs_top_srcdir)/lib"; \
> +       export autom4te_perllibdir; \
>         $(HELP2MAN) \
>             --include=$*.x \
>             --include=$(srcdir)/common.x \
> -           address@hidden `echo '$*' | sed 's,.*/,,'`
> +           address@hidden '$(binsrcdir)/$*'
>         if sed $(remove_time_stamp) $@ >address@hidden 2>/dev/null && \
>            sed $(remove_time_stamp) address@hidden | cmp address@hidden - 
> >/dev/null 2>&1; 
> then \
>                 touch $@; \

Naa, let's just build the wrappers upon `all', that should fix this for
good.  I've installed the patch below.

Cheers,
Ralf

        * tests/Makefile.am (noinst_SCRIPTS): Renamed from
        check_SCRIPTS.  Building the wrappers for `all' allows help2man
        to use them for the manpages.
        Report by Benoit Sigoure.

diff --git a/tests/Makefile.am b/tests/Makefile.am
index fd15563..91b09e2 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -1,6 +1,6 @@
 ## Make Autoconf tests.
 
-# Copyright (C) 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007
+# Copyright (C) 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008
 # Free Software Foundation, Inc.
 
 # This program is free software: you can redistribute it and/or modify
@@ -21,8 +21,8 @@
 EXTRA_DIST = $(TESTSUITE_AT) local.at mktests.sh \
             atlocal.in package.m4 wrapper.as
 
-# Running the uninstalled scripts.
-check_SCRIPTS = $(wrappers)
+# Running the uninstalled scripts.  Build them upon `all', for the manpages.
+noinst_SCRIPTS = $(wrappers)
 DISTCLEANFILES = atconfig atlocal $(TESTSUITE)
 MAINTAINERCLEANFILES = Makefile.in