[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] Be nice with file systems that don't handle unusual char
From: |
Paul Eggert |
Subject: |
Re: [PATCH 3/3] Be nice with file systems that don't handle unusual characters. |
Date: |
Wed, 02 Jan 2008 16:16:12 -0800 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) |
Thanks for those three patches (in
<http://lists.gnu.org/archive/html/autoconf-patches/2007-12/msg00070.html>,
<http://lists.gnu.org/archive/html/autoconf-patches/2007-12/msg00069.html>,
<http://lists.gnu.org/archive/html/autoconf-patches/2007-12/msg00071.html>).
I assume the 3rd patch is still experimental and not meant to be installed
yet. In reviewing the first two I see a minor issue:
+# Neutralize special characters interpreted by sed in replacement strings.
+case $configure_input in #(
+ *'&'*) ac_sed_conf_input=`AS_ECHO(["$configure_input"]) |
+ sed 's/\\\\/\\\\\\\\/g;s/&/\\\\\\&/g'`;; #(
I'm a bit lost here, but shouldn't this check for \ in
$configure_input as well? Also, wouldn't the last line be a bit
simpler as:
sed 's/[[\\\\&]]/\\\\&/g'`;; #(
- Re: [PATCH 3/3] Be nice with file systems that don't handle unusual characters.,
Paul Eggert <=