[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] Clean up the rule to create "expr".
From: |
Jim Meyering |
Subject: |
[PATCH] Clean up the rule to create "expr". |
Date: |
Tue, 13 Nov 2007 09:41:25 +0100 |
This fixes another redirect-directly-to-target nit:
diff --git a/ChangeLog b/ChangeLog
index 79c6cc1..86cccd2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2007-11-13 Jim Meyering <address@hidden>
+
+ Clean up the rule to create "expr".
+ * tests/Makefile.am (expr): Don't redirect directly to target.
+ Redirect just once, not for each echo statement.
+ Use $@, not literal "expr".
+
2007-11-13 Paul Eggert <address@hidden>
Don't worry about preprocessor when testing long long.
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 4cf7fd1..fd15563 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -195,14 +195,17 @@ maintainer-check: maintainer-check-posix
maintainer-check-c++
# The hairy heredoc is more robust than using echo.
CLEANFILES += expr
expr:
- echo '#! $(SHELL)' >expr
- echo 'result=`$(EXPR) "$$@"`'>>expr
- echo 'estatus=$$?' >>expr
- echo 'cat <<EOF' >>expr
- echo '$${result:-0}' >>expr
- echo 'EOF' >>expr
- echo 'exit $$estatus' >>expr
- chmod +x expr
+ :;{ \
+ echo '#! $(SHELL)'; \
+ echo 'result=`$(EXPR) "$$@"`'; \
+ echo 'estatus=$$?'; \
+ echo 'cat <<EOF'; \
+ echo '$${result:-0}'; \
+ echo 'EOF'; \
+ echo 'exit $$estatus'; \
+ } > address@hidden
+ chmod +x address@hidden
+ mv address@hidden $@
# Try the test suite with more severe environments.
maintainer-check-posix: expr
--
1.5.3.5.643.g40e25
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH] Clean up the rule to create "expr".,
Jim Meyering <=