[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix distcheck for Autoconf
From: |
Ralf Wildenhues |
Subject: |
Re: Fix distcheck for Autoconf |
Date: |
Tue, 6 Nov 2007 05:20:37 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Hello Benoit,
* Benoit Sigoure wrote on Tue, Nov 06, 2007 at 01:05:08AM CET:
> On Nov 5, 2007, at 9:41 PM, Ralf Wildenhues wrote:
> >2007-11-05 Ralf Wildenhues <address@hidden>
> >
> > Fix distcheck for Autoconf.
> > * tests/Makefile.am ($(srcdir)/package.m4): Only update
> > if contents have changed.
>
> May I ask why this isn't an AC_CONFIG_FILES? (which is what I did
> for my set of Boost macros and works fine as long as you get the
> dependencies right, which was a mistake I posted some days ago)
AC_CONFIG_FILES should not live in the source tree and should not be
packaged.
Our manual even states:
| Be sure to distribute @file{package.m4} and to put it into the source
| hierarchy: the test suite ought to be shipped!
Oh darn, it also even recommends the rule that is broken wrt. the bash
bug. I forgot to search the manual for instances of this issue (can't
find more than this one though).
Cheers,
Ralf
2007-11-06 Ralf Wildenhues <address@hidden>
* doc/autoconf.texi (Making testsuite Scripts):
diff --git a/doc/autoconf.texi b/doc/autoconf.texi
index 9025359..5f9f8e3 100644
--- a/doc/autoconf.texi
+++ b/doc/autoconf.texi
@@ -20221,8 +20221,10 @@ we suggest that you also define @code{AT_PACKAGE_NAME},
suggest the following makefile excerpt:
@smallexample
+# The initial `:' works around a bash redirection bug.
$(srcdir)/package.m4: $(top_srcdir)/configure.ac
- @{ \
+ :; \
+ @{ \
echo '# Signature of the current package.'; \
echo 'm4_define([AT_PACKAGE_NAME], [@@PACKAGE_NAME@@])'; \
echo 'm4_define([AT_PACKAGE_TARNAME], [@@PACKAGE_TARNAME@@])'; \