[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Make inter-release --version output more useful.
From: |
Jim Meyering |
Subject: |
Re: [PATCH] Make inter-release --version output more useful. |
Date: |
Sat, 27 Oct 2007 21:09:21 +0200 |
Ralf Wildenhues <address@hidden> wrote:
> * Jim Meyering wrote on Sat, Oct 27, 2007 at 07:38:23PM CEST:
> [...git-version-gen...]
>> + COREUTILS-[0-9]*) v=`echo "$v" | sed 's/^COREUTILS-//;s/_/./g'` ;;
>
> Does that need adjustment for Autoconf?
No, since autoconf's preceding tag is of the right form.
It's harmless, and I preferred to keep the scripts in sync.
As the comment above says, that line will be removed pretty soon,
at which point I'll sync here, too.
> [...]
>> diff --git a/tests/Makefile.am b/tests/Makefile.am
>> index c1141c6..1972d6c 100644
>> --- a/tests/Makefile.am
>> +++ b/tests/Makefile.am
>> @@ -34,7 +34,7 @@ include ../lib/freeze.mk
>> ## package.m4. ##
>> ## ------------ ##
>>
>> -$(srcdir)/package.m4: $(top_srcdir)/configure.ac
>> +$(srcdir)/package.m4: $(builddir)/Makefile
>
> Please make that `Makefile', not `$(builddir)/Makefile'. Non-GNU make
> don't all identify `file' with `./file'.
Good point. Done.
> * Jim Meyering wrote on Sat, Oct 27, 2007 at 08:11:39PM CEST:
>>
>> I suppose we should be using gnulib-tool to pull in
>> build-aux files, including announce-gen.
>
> Why? Except for announce-gen, all files are installed by `automake -a'.
So, what do you think about removing them and suggesting automake -a
in README-hacking?
Re: [PATCH] Make inter-release --version output more useful., Ralf Wildenhues, 2007/10/27