[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: don't fail test #132
From: |
Ralf Wildenhues |
Subject: |
Re: don't fail test #132 |
Date: |
Sat, 27 Oct 2007 18:26:03 +0200 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Hello Jim,
* Jim Meyering wrote on Sat, Oct 27, 2007 at 05:40:51PM CEST:
>
> Since you recently made a change in this area,
> I'd like to make sure that this is ok with you
> before I push.
Thanks, for the report and for waiting with the commit.
> The problem is that test #132 now fails due to
> a configure script in a directory earlier than "." in PATH.
Ah, ok, I hadn't thought of that. Then we should put "." early in PATH,
so that this false failure won't happen. Does this patch fix the test
failure for you?
> Normally, I would have changed this
> /bin/sh configure ...
> to this:
> /bin/sh ./configure ...
> but then it'd be identical to the preceding line,
> so this patch simply removes the offending test.
Nono, the test is to explicitly exercise functionality for which code
had been present for a long time in Autoconf, but it was subtly broken
so.
> 2007-10-27 Jim Meyering <address@hidden>
>
> + Don't fail test #132 when there's a configure script in your PATH.
> + * tests/torture.at: Don't depend on "/bin/sh configure" to run
> + ./configure: there may be another configure script earlier in PATH.
A very minor nit: since the test numbers change regularly, it's better
to list them by their name. vc-chlog can help you extract them easily,
with this setting in ~/.ctags (for exuberant ctags):
--langdef=m4
--langmap=m4:.m4.at.ac.as.m4sh
--regex-m4=/^(m4_def(ine|un(|_once))|A[CU]_DEFUN(|_ONCE)|AU_ALIAS)\(\[*([a-zA-Z0-9_()+]+)/\5/d,definition/
--regex-m4=/^AT_SETUP\(\[*([^])]*)\]*\)/\1/d,definition/
Cheers,
Ralf
2007-10-27 Ralf Wildenhues <address@hidden>
Fix `Deep Package' failure with a configure script early in PATH
* tests/torture.at (Deep Package): Add `.' early in PATH.
Report by Jim Meyering.
diff --git a/tests/torture.at b/tests/torture.at
index 4ffaafb..d537eb9 100644
--- a/tests/torture.at
+++ b/tests/torture.at
@@ -1160,7 +1160,7 @@ chmod a-w inner/innermost inner
AT_CHECK([./configure --help=recursive | grep " INNER "], 0, [ignore])
AT_CHECK([./configure --help=recursive | grep " INNERMOST "], 0, [ignore])
AT_CHECK([/bin/sh ./configure --help=recursive | grep " INNERMOST "], 0,
[ignore])
-AT_CHECK([/bin/sh configure --help=recursive | grep " INNERMOST "], 0,
[ignore])
+AT_CHECK([PATH=.$PATH_SEPARATOR$PATH; export PATH; /bin/sh configure
--help=recursive | grep " INNERMOST "], 0, [ignore])
AT_CHECK([PATH=.$PATH_SEPARATOR$PATH; export PATH; configure --help=recursive
| grep " INNERMOST "], 0, [ignore])
chmod u+w inner inner/innermost