autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: m4_defn overhead


From: Eric Blake
Subject: Re: m4_defn overhead
Date: Thu, 11 Oct 2007 13:19:23 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Ralf Wildenhues on 10/11/2007 11:21 AM:
>>      (m4_append): Likewise, and quote the separator.
> 
> This patch causes a regression with CVS Libtool: its configure script is
> unusably botched with this.  More specifically, when I revert the hunk
> below, things look better, but I haven't analysed this further.  I can't
> even tell whether it's Libtool to blame (but even if it is, we may want
> to be a bit careful anyway).  If it's not, then some Autoconf testsuite
> addition would seem to be in order.

Before the patch, m4_append and m4_append_uniq disagreed as to whether
separator should be quoted.  I went with the latter, apparently libtool
wants the former.  Adjusted semantics, along with testsuite additions,
coming up soon.

>>  m4_define([m4_append],
>>  [m4_define([$1],
>> -       m4_ifdef([$1], [m4_defn([$1])$3])[$2])])
>> +       m4_ifdef([$1], [m4_builtin([defn], [$1])[$3]])[$2])])
                                                   ^^^^
- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHDnc784KuGfSFAYARAl40AKC9fH5PWnG5tbc0clguMVpOVtIFFQCfddIr
LHtJwI1dLA8YGP0iz2x9kb4=
=FgyO
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]