Re: [PATCH] use shell functions to check exit codes

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Paolo Bonzini on 10/5/2007 1:55 AM:
> This patch abstract the case statements used to check exit codes
> into two shell functions (one for exit code `ignore', and one for
> the others).
> 
>  
> +at_check_skip () {

Same comment as before on function namespace.  Also, please add comments
before the function, showing expected usage.

> +m4_if([$2], [ignore], [at_check_skip], [at_check_status m4_default([$2], 
> [0])]) $at_status "$at_srcdir/AT_LINE"

Please wrap this line at 80 columns.  I might write it:

m4_if([$2], [ignore], [at_check_skip],
      [at_check_status m4_default([$2], [0])]) \
         $at_status "$at_srcdir/AT_LINE"

After those nits, this looks okay to commit.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHBoyX84KuGfSFAYARAlPQAJ0QV01ssQcnf8V7vKa9aRmRkcThlQCeMoWz
0Z1vxeTagoUvf/aQxTMnodw=
=tdj0
-----END PGP SIGNATURE-----