Re: [PATCH] another shell function, this time to group failure code

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Paolo Bonzini on 10/5/2007 1:53 AM:
> This patch uses shell functions to trim the code that is executed in case
> of failure and remove an m4 iteration.
> 
> 2007-10-04  Paolo Bonzini  <address@hidden>
> 
>       * general.m4 (AT_INIT): Add at_log_failure shell function.
>       (_AT_CHECK): Use it.
> +at_log_failure ()

I'm wondering if we should use the at_func_* namespace for functions
(compare how libtool uses lt_func_ for all functions).  Partly because
some shells still aren't very good at distinguishing between function and
variable namespaces, and using an explicit namespace avoids any chance of
problematic conflicts.

> +{
> +  for file

Does this safely iterate over function arguments, or is it likely to
iterate over the original ./testsuite arguments on some broken shells?

The rest of the patch looks fine.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHBot584KuGfSFAYARAhJkAJwNxbpz84AcD1rBoyE3/O1O2sXOMQCfQpUW
mrmYOY/m+eVSbqNyiWo7At4=
=nVr1
-----END PGP SIGNATURE-----