Re: fix last weekend's regressions in AC_DEFINE

[Ralf Wildenhues]

Hello Eric,

* Eric Blake wrote on Mon, Oct 01, 2007 at 06:12:18PM CEST:
> Sorry for the breakage; and at least the AC_F77_WRAPPERS caught it.

Thanks for your work on this, and for the git help in the other thread.

> +2007-10-01  Eric Blake  <address@hidden>
> +
> +       Fix regression in AC_DEFINE([macro(with_arg)]).
> +       * lib/autoconf/general.m4 (AC_DEFINE_TRACE): Don't chop off close
> +       quotes with a careless m4_substr.
> +

FWIW, the ChangeLog entry is a bit misleading, as
  AC_DEFINE([MACRO([with], [args])])

is broken with respect to autoheader anyway.  One needs to use
  AC_DEFINE(MACRO([with], [args]))

instead, otherwise the template will not be right.  IOW, with
  AC_INIT
  AC_CONFIG_HEADERS([config.h])
  AC_DEFUN([FOO], [$1])
  AC_DEFINE([FOO([BAR])], 1, [text])
  AC_OUTPUT

config.h.in contains FOO rather than BAR.  I assume there is other code
out there besides _AC_F77_WRAPPERS that uses the lesser quotation BTW.

>  m4_define([AC_DEFINE_TRACE],
>  [AS_LITERAL_IF([$1], [AC_DEFINE_TRACE_LITERAL(
> -  m4_if(m4_index([[$1]], [(]), [-1], [[$1]],
> -       [m4_substr([[$1]], [0], m4_index([[$1]], [(]))]))])])
> +  m4_if(m4_index([$1], [(]), [-1], [[$1]],

Was this change in the first argument to m4_index from [[$1]] to [$1]
fixing some issue, too?  If not, can it break some user code?  Thanks.

> +       [m4_bpatsubst([[$1]], [(.*)])]))])])

Cheers,
Ralf