autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix chdir-long.m4 caching


From: Eric Blake
Subject: Re: Fix chdir-long.m4 caching
Date: Thu, 27 Sep 2007 22:33:05 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Ralf Wildenhues on 9/26/2006 12:03 PM:
> Hello Eric, Stepan,

Hello all, and continuing with another old, unapplied patch (from the same
thread, even!)

>> FWIIW, I canot see any problem with Ralf's version either.
> 
> Well, here you go.  First, the patch makes the `AC_CACHE_CHECK' test
> fail, so is incomplete.  So here's a patch to fix the test, also test
> that we warn in the literal case, and add a case with a m4 macro.  This
> is where my previous patch failed.  I guess you'd suggest I need to rip
> off a set of `[]' quotes from the second argument of AC_CACHE_CHECK.
> I'd argue that this could be a backward incompatibility for user code.

This complaint of Ralf was solved by Stepan with a 2006-10-14 check-in,
leaving just:

> 
> So here's an updated patch that hopefully catches this as well.  I'll
> apply in a couple of days, given absense of objections.  (I'm usually a
> bit reluctant to just "fix" testcases: after all, somebody may have
> added them on purpose, so that exactly that code continues to work as
> intended.)
> 
> Cheers,
> Ralf
> 
> 
> 2006-09-26  Eric Blake  <address@hidden>
>       and Ralf Wildenhues  <address@hidden>
> 
>       * lib/autoconf/general.m4 (AC_CACHE_VAL): Warn if cache-id is not
>       cached.
>       * tests/base.at (AC_CACHE_CHECK): Adjust test to expect this,
>       also test that macro names and correct literals are not checked.

Applied as follows:

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG/IQA84KuGfSFAYARAm2mAKDPEjhCFHApnHtLrwOfTF8iH94Z8wCgmjAt
XSJYwQALAMhFLzmHqMdEf2s=
=KFN1
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]