autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: parallel make bug


From: Noah Misch
Subject: Re: parallel make bug
Date: Thu, 24 May 2007 07:05:13 -0700
User-agent: Mutt/1.5.9i

On Thu, May 24, 2007 at 06:50:05AM -0600, Eric Blake wrote:
> With make -j2, after bin/autom4te.in has been edited, I got this failure:
> 
> /bin/sh: ../bin/autom4te: No such file or directory
> make[1]: *** [autoconf.in] Error 127
> make[1]: *** Waiting for unfinished jobs....
> 
> Is this patch correct for installation?  I tested with an in-tree build,
> so I'm a bit worried that I may have missed a VPATH subtlety.
> 
> 2007-05-24  Eric Blake  <address@hidden>
> 
>       * bin/Makefile.am (autoconf.in): Depend on autom4te.

I can reproduce the problem here.  The race ends differently on my system, so I
get this failure:

make[1]: *** No rule to make target `../bin/autom4te', needed by `autoconf.in'. 
 Stop.

This patch fixes the problem:

--- ./bin/Makefile.am~  2007-05-05 00:39:13.000000000 -0400
+++ ./bin/Makefile.am   2007-05-24 09:40:36.000000000 -0400
@@ -54,6 +54,8 @@
        -e 's|@address@hidden|$(PACKAGE_NAME)|g' \
        -e 's|@address@hidden|Generated from address@hidden; do not edit by 
hand.|g'
 
+$(top_builddir)/bin/autom4te: autom4te
+
 # autoconf is written in M4sh.
 # FIXME: this target should depend on the frozen files below lib/m4sugar,
 # otherwise autom4te may pick up a frozen m4sh.m4f from an earlier


Still, I am not too sure that this is the last makefile bug in the way of a safe
`make -j'.  Given how little the build process benefits from parallelism, we may
be better off keeping the current recommendation against it.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]