Re: Building universal binaries makes 'check' fail

[Paul Eggert]

"Peter O'Gorman" <address@hidden> writes:

> There are quite a number of software packages
> out there that do not use config headers for whatever reason.

OK, thanks, I installed this:

2007-03-05  Paul Eggert  <address@hidden>

        * doc/autoconf.texi (C Compiler): Warn that AC_C_BIGENDIAN
        suggests AC_CONFIG_HEADERS.
        * lib/autoconf/c.m4 (AC_C_BIGENDIAN): Warn if not using
        AC_CONFIG_HEADERS.  Problem reported by
        Peter O'Gorman.

Index: doc/autoconf.texi
===================================================================
RCS file: /cvsroot/autoconf/autoconf/doc/autoconf.texi,v
retrieving revision 1.1133
diff -u -p -r1.1133 autoconf.texi
--- doc/autoconf.texi   28 Feb 2007 00:03:33 -0000      1.1133
+++ doc/autoconf.texi   6 Mar 2007 07:30:13 -0000
@@ -6486,6 +6486,11 @@ abort configure and tell the installer h
 And finally, the default for @var{action-if-universal} is to define
 @samp{WORDS_BIGENDIAN} or not, depending on the architecture that the
 code is being generated for.
+
+If you use this macro without specifying @var{action-if-universal}, you
+should also use @code{AC_CONFIG_HEADERS}; otherwise
address@hidden may be set incorrectly for Mac OS X universal
+binary files.
 @end defmac

 @defmac AC_C_CONST
Index: lib/autoconf/c.m4
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/autoconf/c.m4,v
retrieving revision 1.244
diff -u -p -r1.244 c.m4
--- lib/autoconf/c.m4   1 Mar 2007 00:18:28 -0000       1.244
+++ lib/autoconf/c.m4   6 Mar 2007 07:30:13 -0000
@@ -1,6 +1,6 @@
 # This file is part of Autoconf.                       -*- Autoconf -*-
 # Programming languages support.
-# Copyright (C) 2001, 2002, 2003, 2004, 2005, 2006 Free Software
+# Copyright (C) 2001, 2002, 2003, 2004, 2005, 2006, 2007 Free Software
 # Foundation, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
@@ -1381,15 +1381,17 @@ AC_DEFUN([AC_C_BIGENDIAN],
 #endif])dnl
  AC_CACHE_CHECK([whether byte ordering is bigendian], [ac_cv_c_bigendian],
    [ac_cv_c_bigendian=unknown
-    # See if __BIG_ENDIAN__ or __LITTLE_ENDIAN__ is defined.
-    AC_COMPILE_IFELSE(
-      [AC_LANG_SOURCE(
-        [[#if ! (defined __BIG_ENDIAN__ || defined __LITTLE_ENDIAN__)
-           neither is defined;
-         #endif
-         typedef int dummy;
-        ]])],
-      [ac_cv_c_bigendian=universal])
+    m4_ifval(m4_ifdef([AH_HEADER], 1)[$4],
+      [# See if __BIG_ENDIAN__ or __LITTLE_ENDIAN__ is defined.
+       AC_COMPILE_IFELSE(
+        [AC_LANG_SOURCE(
+           [[#if ! (defined __BIG_ENDIAN__ || defined __LITTLE_ENDIAN__)
+              neither is defined;
+            #endif
+            typedef int dummy;
+           ]])],
+        [ac_cv_c_bigendian=universal])],
+      [AC_DIAGNOSE([obsolete], [AC_C_BIGENDIAN suggests AC_CONFIG_HEADERS])])
     if test $ac_cv_c_bigendian = unknown; then
       # See if sys/param.h defines the BYTE_ORDER macro.
       AC_COMPILE_IFELSE(