Re: Fix chdir-long.m4 caching

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

PING

According to Stepan Kasal on 9/29/2006 8:46 AM:
> Hello,
> 
> On Wed, Sep 27, 2006 at 07:29:45PM +0200, I proposed:
>> ``The right way'' first.
>>
>> 1a)
>> I think that it would be best for consistency to write:
>>   AC_CACHE_CHECK([for $1], [ac_var], ...
>> and then remove the [] quotes from the definition of AC_CACHE_CHECK.
> 
...

> 
> So I did the one line change to AS_LITERAL_IF, did many changes in
> the indirect callers of it, and wrote a test case.
> 
> The resulting patch is attached here.
> 
> Can this bring some backward compatibility problems?
> As I said before, I hope the problems should be rare.
> After a consultation with Ralf Cautious Wildenhues, I tested the
> patch with libtool (details below).  And I verified that my patch
> passes the test suites of Autoconf and Automake.
> 
> So I believe the patch is safe.  OK to commit?

Anyone else care to review this patch?  I've been running with it in my
local tree with no apparent adverse affects.

> 
> 2006-09-29  Stepan Kasal  <address@hidden>
> 
>       * lib/m4sugar/m4sh.m4 (AS_LITERAL_IF): Expand $1 before
>       looking for special shell characters.
>       * lib/autoconf/functions.m4 (AC_CHECK_FUNC): Do not expand the
>       macro defined by AS_VAR_PUSHDEF before passing it as a
>       parameter.
>       * lib/autoconf/general.m4 (AC_CHECK_FILE, AC_CHECK_DECL):
>       * lib/autoconf/libs.m4 (AC_SEARCH_LIBS, AC_CHECK_LIB):
>       * lib/autoconf/types.m4 (_AC_CHECK_TYPE_NEW, AC_CHECK_MEMBER):
>       * lib/autoconf/headers.m4 (_AC_CHECK_HEADER_MONGREL,
>       _AC_CHECK_HEADER_NEW, _AC_CHECK_HEADER_OLD,
>       _AC_CHECK_HEADER_DIRENT): Likewise.
>       * lib/autotest/general.m4 (AT_INIT): Quote parameters of
>       AS_VAR_* properly.
>       * tests/m4sh.at (AS_LITERAL_IF): New test.

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFMN5k84KuGfSFAYARAn7qAJ9HlCMTN0L+CKR6JwmbpboKHXbIFgCeM99D
eOU4culhQgYPj9udJvPFjdo=
=hrDT
-----END PGP SIGNATURE-----