Re: Patch to the Erlang macros

[Ralf Wildenhues]

Hello Romain,

* Romain Lenglet wrote on Tue, Sep 05, 2006 at 09:55:09AM CEST:
> 
> Here is a small patch that enhances one of the Erlang-related 
> macro to substitute a new variable.  The documentation is 
> updated.   Is that OK?

Small nit below.  Other than that, it looks ok to me (but I don't know
zilch about Erlang).

Cheers,
Ralf

>  # AC_ERLANG_CHECK_LIB(LIBRARY, [ACTION-IF-FOUND], [ACTION-IF-NOT-FOUND])
>  # -------------------------------------------------------------------
>  AC_DEFUN([AC_ERLANG_CHECK_LIB],
>  [AC_REQUIRE([AC_ERLANG_PATH_ERLC])[]dnl
>  AC_REQUIRE([AC_ERLANG_PATH_ERL])[]dnl
> +AC_REQUIRE([AC_PROG_SED])[]dnl

Why do you need AC_PROG_SED and $SED?  Your script below is short and
your input should not have too long lines, right?  Then you could just
use plain sed, as is done in several places in Autoconf.

>  AC_CACHE_CHECK([for Erlang/OTP '$1' library subdirectory],
>      [erlang_cv_lib_dir_$1],
>      [AC_LANG_PUSH(Erlang)[]dnl
> @@ -203,14 +205,21 @@
>              end,
>              halt(ReturnValue)])],
>          [erlang_cv_lib_dir_$1=`cat conftest.out`],
> -        [if ! test -f conftest.out; then
> +        [if test ! -f conftest.out; then

Good catch.

> +        [erlang_cv_lib_ver_$1=`echo "$erlang_cv_lib_dir_$1" | $SED -n -e 
> 's,^.*-\([[^/-]]*\)$,\1,p'`])[]dnl