autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GNU Autoconf 2.60] testsuite: 95 failed


From: Ralf Wildenhues
Subject: Re: [GNU Autoconf 2.60] testsuite: 95 failed
Date: Fri, 7 Jul 2006 20:34:17 +0200
User-agent: Mutt/1.5.11+cvs20060403

Hello Paul, Keith,

* Paul Eggert wrote on Fri, Jul 07, 2006 at 08:00:02PM CEST:
> Ralf Wildenhues <address@hidden> writes:
> 
> >     * tests/torture.at (Configuring subdirectories): Another
> >     instance of configure that needs CONFIG_SITE set.
> 
> How about this more-general patch instead?  It tries to kill off
> CONFIG_SITE for the entire test.  I'd rather not track down the
> CONFIG_SITE usages one by one.

Looks ok to me (untested).  Doesn't Autotest though guarantee that each
test runs in its own subshell, saving you from the need to unset, which
also saves you from the fact that CONFIG_SITE may be needed for good
testsuite exposure.  (If this guarantee isn't given, or not set in stone
in the documentation, then it should be IMVHO.)

> Perhaps we should even turn off CONFIG_SITE altogether for tests.

I've thought that before; it may be necessary in the end.  However, I'd
like to wait with that, let's say another bug report or two.  Also, it's
very unfortunate as using CONFIG_SITE to our advantage enables to test
more (e.g., currently we don't have a good way to pass --host to all
configure scripts in the test suite, to harrass a cross compiler).

> Anyway, I installed this (before reading your email).  This
> patch assumes you didn't apply my earlier patch.

Thanks.  Keith, if you'd like to test, you can speed up your testing by
running this after applying the patch:

  make check TESTSUITEFLAGS='-v -d 95'

assuming that 95 was the right test number, else

  make check TESTSUITEFLAGS='-v -d -k autoreconf'

(for non-GNU make the syntax is a bit different).

Cheers,
Ralf

> 2006-07-07  Paul Eggert  <address@hidden>
> 
>       * tests/torture.at (Configuring subdirectories): Set CONFIG_SITE
>       more globally, since the 2006-06-30 patch didn't suffice.  Problem
>       reported by Keith Marshall.  Also, don't bother with builddir2,
>       since it shouldn't be needed any more.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]