[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Make AC_COMPUTE_INT public
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] Make AC_COMPUTE_INT public |
Date: |
Tue, 20 Jun 2006 12:44:19 +0200 |
User-agent: |
Mutt/1.5.11 |
* Paolo Bonzini wrote on Tue, Jun 20, 2006 at 11:00:23AM CEST:
>
> >Please mark PROLOGUE as optional.
> It is not really optional in _AC_COMPUTE_INT_{COMPILE,RUN}: an empty
> argument happens to not give errors, but only AC_COMPUTE_INT uses
> AC_INCLUDES_DEFAULT.
Hehe, nice catch. Although, upon rereading again, I noticed that
AC_LANG_INT_SAVE(C) includes stdio.h and stdlib.h unconditionally,
saving us from requiring users to force-include any headers . So
you could just remove the sentence to this end. (Note that, if
this were not the case, most gnulib usages of _AC_COMPUTE_INT would
be buggy.)
> [...] Furthermore, the range of the value
> +should be one bit less than the size of a @code{signed long}. That is,
> +for a system where @code{long} is 32-bit, the value should be between
> address@hidden << 30} and @code{1 << 30}, excluding the extrema).
Remove these sentences, too. Upon rereading the macro, I think it
should work fine up to LONG_MAX, barring any hidden bugs. (Sorry
for the rough first review, it was done, erm, a bit in a rush. ;-)
I'd say apply with these changes. I guess if any of the other
developers have a problem with this, they will speak up. ;-)
(Anyway I have two more patches to be posted and reviewed, but
not today.)
Cheers,
Ralf
- Re: [PATCH] Make AC_COMPUTE_INT public, Paolo Bonzini, 2006/06/19
- Re: [PATCH] Make AC_COMPUTE_INT public, Ralf Wildenhues, 2006/06/19
- Re: [PATCH] Make AC_COMPUTE_INT public, Ralf Wildenhues, 2006/06/20
- Re: [PATCH] Make AC_COMPUTE_INT public, Paolo Bonzini, 2006/06/20
- Re: [PATCH] Make AC_COMPUTE_INT public,
Ralf Wildenhues <=
- Re: [PATCH] Make AC_COMPUTE_INT public, Paul Eggert, 2006/06/20
- Re: [PATCH] Make AC_COMPUTE_INT public, Ralf Wildenhues, 2006/06/21
- Re: [PATCH] Make AC_COMPUTE_INT public, Paolo Bonzini, 2006/06/22
- Re: [PATCH] Make AC_COMPUTE_INT public, Ralf Wildenhues, 2006/06/22
- Re: [PATCH] Make AC_COMPUTE_INT public, Paolo Bonzini, 2006/06/27
- Re: [PATCH] Make AC_COMPUTE_INT public, Paul Eggert, 2006/06/27
- Re: [PATCH] Make AC_COMPUTE_INT public, Paolo Bonzini, 2006/06/28
- Re: [PATCH] Make AC_COMPUTE_INT public, Paolo Bonzini, 2006/06/28
- Re: [PATCH] Make AC_COMPUTE_INT public, Stepan Kasal, 2006/06/28
- Re: [PATCH] Make AC_COMPUTE_INT public, Paolo Bonzini, 2006/06/28