autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Mingw-users] Re: MSYS ln -s to directory


From: Ralf Wildenhues
Subject: Re: [Mingw-users] Re: MSYS ln -s to directory
Date: Tue, 11 Apr 2006 14:23:50 +0200
User-agent: Mutt/1.5.11

Hi Keith,

Thank you for your persistence!

* Keith MARSHALL wrote on Tue, Apr 11, 2006 at 01:18:47PM CEST:
> 
> To (hopefully) put this to bed, here's how MSYS handles various
> possibilities on NTFS:
> 

>   $ ln [dir1/]file dir2              ; # fails

Does this also fail if `dir2' is `.'?  I'm a bit unsure about whether we
should test this in the code, or discourage it in the documentation.

*snip*
> Any other permutations you think we should check?

No, but the current code has two bugs, the second hiding the first.
OK to apply this (I'll add Keith to THANKS) to fix them?  Or rather
only put the `rm' in and change the documentation for `ln'?

Cheers,
Ralf

        * lib/m4sugar/m4sh.m4 (_AS_LN_S_PREPARE): If `ln -s file1 file2'
        succeeded, but `ln -s file dir' failed, take care to remove the
        leftover target before the next test, to prevent its spurious
        failure; also make sure `ln file dir' works before selecting it.
        Thanks to Keith Marshall for pointing this out.

Index: lib/m4sugar/m4sh.m4
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/m4sugar/m4sh.m4,v
retrieving revision 1.178
diff -u -r1.178 m4sh.m4
--- lib/m4sugar/m4sh.m4 10 Apr 2006 17:55:33 -0000      1.178
+++ lib/m4sugar/m4sh.m4 11 Apr 2006 11:41:28 -0000
@@ -877,7 +877,9 @@
   else
     as_ln_s='ln -s'
   fi
-elif ln conf$$.file conf$$ 2>/dev/null; then
+elif rm -f conf$$ conf$$.dir/conf$$.file &&
+     ln conf$$.file conf$$ 2>/dev/null &&
+     ln conf$$.file conf$$.dir 2>/dev/null; then
   as_ln_s=ln
 else
   as_ln_s='cp -p'




reply via email to

[Prev in Thread] Current Thread [Next in Thread]