Re: Avoid certain spurious `testsuite' rebuilds

[Stepan Kasal]

Hello,

On Mon, Apr 10, 2006 at 01:40:30PM +0200, Ralf Wildenhues wrote:
> * Stepan Kasal wrote on Mon, Apr 10, 2006 at 11:40:33AM CEST:
> >  1) mktests.sh is no longer a maintainer tool, thus 
> > $(TESTSUITE_GENERATED_AT)
> >     are no longer distributed,

> > I understand that mktests.sh is no longer considered maintainer-only, so 
> > this
> > should be OK.
> 
> Dangerous.  I don't like this much.

well, in a sense it is dangerous to build anything on user's machine.

This change simplifies tests/Makefile.am, so I tend to like it.

The prerequisite is a portable implementation of mktests.sh, which is
doable.

> >  2) avoid spurious rebuilds.

> > +$(TESTSUITE).tmp: $(TESTSUITE_dependencies) $(TESTSUITE_GENERATED_AT)
> > +   cd $(top_builddir)/lib/autotest && $(MAKE) $(AM_MAKEFLAGS) autotest.m4f
> > +   $(AUTOTEST) -I $(srcdir) suite.at -o $@
> 
> I don't like a genuine target name that ends in `.tmp' much, to be
> honest.

And what about ``testsuite.new''?

> > Moreover I made the change discussed elsewhere that mktests.sh should
> > fail in the created *.at file happens to be empty.
> 
> You forgot to adjust the part in the trap.

I thought that the trap code is OK (it is triggered by the `exit 1').
What have I missed.

I'll resubmit the two patches in due time.

Have a nice day,
        Stepan