autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Remove the rest of the comment from _AC_CACHE_DUMP


From: Ralf Wildenhues
Subject: Re: Remove the rest of the comment from _AC_CACHE_DUMP
Date: Mon, 10 Apr 2006 11:17:32 +0200
User-agent: Mutt/1.5.11

Hi Stepan,

* Stepan Kasal wrote on Mon, Apr 10, 2006 at 10:57:14AM CEST:
> 
> Isn't this a case where configure tries to be too smart?  Shouldn't
> the sorting be removed?

The non-sorted output and duplication is practically a more important
concern than this small inconsistency (where `more important' is
certainly to be taken relative here; neither are very important at all;
but if you're visually searching for something, a sorted list helps).

> A proposed patch attached (post 2.60, of course).

For post-2.60, you could try to come up with a patch that uniquifies
only the #define components and leaves all others intact, including
order.  For bonus points, you could sort all non-#if*-adorned defines.
Since it's such a nice exercise, and there are non-obvious bits to it,
I'm sure you'll find motivation to do this.   ;->

> --- lib/autoconf/general.m4   9 Apr 2006 06:29:28 -0000       1.905
> +++ lib/autoconf/general.m4   10 Apr 2006 08:41:52 -0000
> @@ -1236,7 +1236,8 @@
>  
>      if test -s confdefs.h; then
>        AS_BOX([confdefs.h.])
> -      sort -u confdefs.h
> +      echo
> +      sed "/^\$/d" confdefs.h

This reintroduces the quoting bug Paul just eliminated.

>        echo
>      fi
>      test "$ac_signal" != 0 &&

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]