autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Remove the rest of the comment from _AC_CACHE_DUMP


From: Stepan Kasal
Subject: Re: Remove the rest of the comment from _AC_CACHE_DUMP
Date: Fri, 7 Apr 2006 17:20:35 +0200
User-agent: Mutt/1.4.1i

Hello,

On Thu, Apr 06, 2006 at 11:56:34PM +0200, Ralf Wildenhues wrote:
> ?  Does your patch fix a bug?

good question.  A confusing comment line in the generated configure
is not severe enough.  Let's put it off after 2.60.

Just for records: the generated configure contains
--- snip ---
trap 'exit_status=$?
...
    echo
    # The following way of writing the cache mishandles newlines in values,
(
--- snip ---
The comment is the first line of a longer comment, and thus doesn't make
much sense.
This might be confusing, but probably does not clasify as a bug.

> # When interrupted or exit'd, cleanup temporary files, and complete
> # config.log.  We remove comments because anyway the quotes in there
> # would cause problems or look ugly.
> # WARNING: Be sure not to use single quotes in there, as some shells,
> # such as our DU 5.0 friend, will then `close' the trap.

The first sentence is good.  The last one hopefully is not true; the code
of the trap uses sigle quotes happily.
I don't know whether sigle quotes in comments might cause problems; I agree
I should not test it now.  It's a matter of taste whether they look ugly.

Let's resolve this after 2.60.

Have a nice day,
        Stepan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]