Re: Remove the rest of the comment from _AC_CACHE_DUMP

[Ralf Wildenhues]

Hi Stepan,

* Stepan Kasal wrote on Thu, Apr 06, 2006 at 08:27:28PM CEST:
> On Thu, Apr 06, 2006 at 08:06:19PM +0200, Stepan Kasal wrote:
> > Well, but why are we trying to remove them?
> > What about the following patch?

What about the following comment above the part you change:
# When interrupted or exit'd, cleanup temporary files, and complete
# config.log.  We remove comments because anyway the quotes in there
# would cause problems or look ugly.
# WARNING: Be sure not to use single quotes in there, as some shells,
# such as our DU 5.0 friend, will then `close' the trap.

?  Does your patch fix a bug?

Cheers,
Ralf

> 2006-04-06  Stepan Kasal  <address@hidden>
> 
>       * lib/autoconf/general.m4 (_AC_INIT_PREPARE): Do not remove comments
>         from _AC_CACHE_DUMP.
> 
> Index: lib/autoconf/general.m4
> ===================================================================
> RCS file: /cvsroot/autoconf/autoconf/lib/autoconf/general.m4,v
> retrieving revision 1.900
> diff -u -r1.900 general.m4
> --- lib/autoconf/general.m4   6 Apr 2006 18:16:56 -0000       1.900
> +++ lib/autoconf/general.m4   6 Apr 2006 18:25:45 -0000
> @@ -1208,10 +1208,7 @@
>  
>      AS_BOX([Cache variables.])
>      echo
> -    m4_bpatsubsts(m4_defn([_AC_CACHE_DUMP]),
> -               [^ *\(#.*\)?
> -],                [],
> -               ['], ['"'"'])
> +    m4_bpatsubsts(m4_defn([_AC_CACHE_DUMP]), ['], ['"'"'])
>      echo
>  
>      AS_BOX([Output variables.])