Re: generated tests/*.at in cvs?

[Ralf Wildenhues]

Hi Paul,

* Paul Eggert wrote on Wed, Apr 05, 2006 at 01:04:52AM CEST:
> Ralf Wildenhues <address@hidden> writes:
> 
> >     * tests/mktests.sh: If `egrep' does not support multiple
> >     patterns separated by newlines, use `-f' instead.
> 
> I'd rather not go down this route, since it creates temporary files
> that have to be cleaned up.  Instead, let's use awk instead.  That
> makes the code easier to read and maintain, since awk scripts can
> contain indentation and comments.

OK, that looks nicer indeed, and more maintainable.  Thanks.

> I installed the following (tested on Debian stable).

Works on several systems.

> As a result of
> the reformatting I discovered some patterns that weren't commented, so
> I put in a "Dunno" comment for them.  If you know why those patterns
> are there, could you please add comments?  Thanks.

See patch below.  I also redid the comments a bit, and fixed a bug
noted by Stepan: our internal macro check used /_AC_/ and not /^_AC_/.
There is only one guy starting with `__AC_'.

The AC_REPLACE_FUNCS without args expands to `... for ac_func in' which
fails with some shells, so they really need an argument.

I have applied the resulting patch (in two pieces), in the hope that
this was ok.

I'm not sure whether just touching the output in an error case is a
sensible thing to do any more: this aims to be portable now, so it
probably should fail, no?

Cheers,
Ralf

        * tests/mktests.sh: Reword comments.

        * tests/mktests.sh: Only skip internal macros starting with
        `_AC_' or `__AC_'.  Noted by Stepan Kasal.
        Update exclusion lists for the test suite to this end:
        (AC_ARG_VAR): Do test this now.
        (AC_REPLACE_FUNCS): This needs an argument.
        (AC_LINKER_OPTION): Remove (renamed to _AC_LINKER_OPTION).
        (AC_LIST_MEMBER_OF): Likewise (renamed to _AC_LIST_MEMBER_IF).
        (AC_LINK_FILES): Obsoleted since (and thus AU_DEFUN'ed).

mktests-comments.diff
Description: Text document

mktests-dunno.diff
Description: Text document