autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: _AC_CACHE_DUMP simplified


From: Paul Eggert
Subject: Re: _AC_CACHE_DUMP simplified
Date: Wed, 05 Apr 2006 16:43:25 -0700
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux)

I like the new patch, and think it should be installed since it fixes
some potential real gotchas.  Some minor comments:

> +    case $ac_val in #(
> +    *${as_nl}?*)

That '?' will cause the code to mishandle vars whose values have a newline
only at the end.  Can't we omit it by....

> +      case $ac_var in #(
> +      _ | IFS) ;; #(

Changing this to "_ | as_nl | IFS"?

> +      *_cv_*) AC_MSG_WARN([Cache variable $ac_var contains a newline.]) ;;
> +      esac
> +      $as_unset $ac_var ;;

It sounds a bit risky to unset _ or IFS.  How about something like this instead?

    eval ac_val=\$$ac_var
    case $ac_val in #(
    *${as_nl}*)
      case $ac_var in #(
      *_cv_*) AC_MSG_WARN([Cache variable $ac_var contains a newline.]) ;;
      esac
      case $ac_var in #(
      _ | IFS | as_nl) ;; #(
      *_cv_*) $as_unset $ac_var ;;
      esac
    esac




reply via email to

[Prev in Thread] Current Thread [Next in Thread]