autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: clean up m4sh.m4, then optimize AS_PATH_WALK


From: Stepan Kasal
Subject: Re: clean up m4sh.m4, then optimize AS_PATH_WALK
Date: Tue, 4 Apr 2006 00:02:53 +0200
User-agent: Mutt/1.4.1i

Hello Ralf,

On Sun, Apr 02, 2006 at 03:43:40PM +0200, Ralf Wildenhues wrote:
> So this patch was not only not fixing a bug, but merely an optimization,
> but also introducing a bug.
>
> Please leave the introduction of bugs to post 2.60 for now, unless you
> also fix actual bugs.  Micro-optimization doesn't count for the latter.

Oh, I see, the problem was that the optimization was too small!  ;-)
I can do better, if you please:

Eric's original problem was that the /usr/bin/posix/{sh,bash,ksh,sh5}
non-existent shells cause four extra forks.  His patch was optimizg out
these forks.

But we can do better!  We can optimize out _all_ extra forks for nonexistent
shells!  I hope you will count this as a bug fix!  :-)

And now for something completely different:

> > > >         * lib/m4sugar/m4sh.m4 (_AS_PATH_WALK): Optimize nonexistent
> > > >         directories, unless optional third argument supplied.
> > > >         (AS_UNAME): Don't optimize PATH walk.

On a second thought, I shouldn't have accepted that patch.
If any caller needs to skip nonexistent directories, he can do so by
insering the command
        test -d "$ac_dir" || continue
to the beginning of the second parameter.

So I'd like to back out Eric's patch, including the autotest fix that I
added later.

The patch follows, I won't commit it now, it's too late now.  ;-)

Have a nice day,
        Stepan

Attachment: autoconf-20060403-path-walk.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]