autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: clean up m4sh.m4, then optimize AS_PATH_WALK


From: Eric Blake
Subject: Re: clean up m4sh.m4, then optimize AS_PATH_WALK
Date: Sat, 01 Apr 2006 12:20:09 -0700
User-agent: Thunderbird 1.5 (Windows/20051201)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Stepan Kasal on 4/1/2006 11:35 AM:
>>      * lib/m4sugar/m4sh.m4: Sort sections as implied by the comments,
>>      and fix some typos.
> 
> I committed both of these, modifying the ``Sort'' one a bit:
> - I made sure there are two empty lines between the individual macros.
> - I moved _AS_MKDIR_P_PREPARE after _AS_MKDIR_P.  (Well, this might
>   have been a mistake, but it's not worth fixing it.)
> The exact form of that patch is attached to this post.

Thanks for the cleanup.

> 
>> 2006-04-01  Eric Blake  <address@hidden>
>>
>>      * lib/m4sugar/m4sh.m4 (_AS_PATH_WALK): Optimize non-existant
>>      directories, unless optional third argument supplied.
>>      (AS_UNAME): Don't optimize PATH walk.

Bah - one patch fixes typos, the other adds them!  How about this followup
(I don't think an extra ChangeLog entry is warranted, since one typo is in
the ChangeLog, and the other is part of what was already documented as
changed today).  I don't have CVS write access to autoconf yet, although
my papers are on file - maybe it's time for me to be given access?

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFELtJp84KuGfSFAYARAk1gAKCBKQq4T7Lcl+GrWxlSU5jTaeqF9gCdHtxE
gN6YOiCJO8TNkudHkPRM8PI=
=i1i0
-----END PGP SIGNATURE-----
Index: ChangeLog
===================================================================
RCS file: /sources/autoconf/autoconf/ChangeLog,v
retrieving revision 1.2753
diff -u -p -r1.2753 ChangeLog
--- ChangeLog   1 Apr 2006 18:33:24 -0000       1.2753
+++ ChangeLog   1 Apr 2006 19:10:28 -0000
@@ -1,6 +1,6 @@
 2006-04-01  Eric Blake  <address@hidden>
 
-       * lib/m4sugar/m4sh.m4 (_AS_PATH_WALK): Optimize non-existant
+       * lib/m4sugar/m4sh.m4 (_AS_PATH_WALK): Optimize nonexistent
        directories, unless optional third argument supplied.
        (AS_UNAME): Don't optimize PATH walk.
 
Index: lib/m4sugar/m4sh.m4
===================================================================
RCS file: /sources/autoconf/autoconf/lib/m4sugar/m4sh.m4,v
retrieving revision 1.169
diff -u -p -r1.169 m4sh.m4
--- lib/m4sugar/m4sh.m4 1 Apr 2006 18:32:10 -0000       1.169
+++ lib/m4sugar/m4sh.m4 1 Apr 2006 19:10:28 -0000
@@ -927,7 +927,7 @@ fi
 
 # _AS_PATH_WALK([PATH = $PATH], BODY, [NO-OPTIMIZE])
 # --------------------------------------------------
-# Walk through PATH running BODY for each `as_dir'.  Skip non-existent
+# Walk through PATH running BODY for each `as_dir'.  Skip nonexistent
 # directories unless NO-OPTIMIZE is specified.
 #
 # Still very private as its interface looks quite bad.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]