autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Autotest: make test dir writable before removing


From: Paul Eggert
Subject: Re: Autotest: make test dir writable before removing
Date: Tue, 04 Oct 2005 12:17:54 -0700
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux)

Ralf Wildenhues <address@hidden> writes:

> +     test -d "$at_suite_dir" &&
> +       find "$at_suite_dir" -type l -prune -o -type d -exec chmod u+rwx \{\} 
> \;
>       rm -f -r "$at_suite_dir" "$at_suite_log"

Why do you need the "-type l -prune" here?  Can't that be omitted?
"find" doesn't follow symlinks.  (Ancient versions of "find" don't
understand either -type l or -prune.)

Similarly for the other uses of "find" and "rm".

Also, as a minor efficiency thing, if $at_suite_dir is not a directory
then you don't need to invoke rm at all; this really only applies to
the other uses, since the only thing they do is remove $at_group_dir.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]