Re: AT_KEYWORDS failure: cmdline OR-combinations

[Ralf Wildenhues]

Hi Paul,

* Paul Eggert wrote on Thu, Aug 25, 2005 at 11:31:30PM CEST:
> Ralf Wildenhues <address@hidden> writes:
> 
> > -   if (v1 == "") d1 = v1; else { d1 = substr(v1, 1, 1); v1 = substr(v1,2) }
> > -   if (v2 == "") d2 = v2; else { d2 = substr(v2, 1, 1); v2 = substr(v2,2) }
> > +   if (v1"" == "") d1 = v1; else { d1 = substr(v1, 1, 1); v1 = 
> > substr(v1,2) }
> > +   if (v2"" == "") d2 = v2; else { d2 = substr(v2, 1, 1); v2 = 
> > substr(v2,2) }
> 
> That looks fairly safe, but even safer would be to use the length function,
> since earlier bits of the code already do that.  I installed this:

Hate to tell you, but Stepan and I have been working on this more,
off-list.  He's done the analyzing part and has come up with a more
comprehensive fix, I've merely executed the tests.  I suppose he will
announce his final patch soon.

But thanks anyway!

Cheers,
Ralf