[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: A simplification of _AC_CANONICAL_SPLIT
From: |
Noah Misch |
Subject: |
Re: A simplification of _AC_CANONICAL_SPLIT |
Date: |
Tue, 16 Aug 2005 12:45:14 -0700 |
User-agent: |
Mutt/1.5.6i |
On Tue, Aug 16, 2005 at 07:05:46PM +0200, Stepan Kasal wrote:
> --- lib/autoconf/general.m4 16 Aug 2005 09:11:06 -0000 1.880
> +++ lib/autoconf/general.m4 16 Aug 2005 16:49:15 -0000
> @@ -1659,19 +1659,14 @@
> ac_save_IFS=$IFS; IFS='-'
> set x $ac_cv_$1
> shift
> -IFS=$ac_save_IFS
> -
> AC_SUBST([$1_cpu], [$[1]])dnl
> AC_SUBST([$1_vendor], [$[2]])dnl
> -AC_SUBST([$1_os], [$[3]])dnl
> case $[#] in
> -0|1|2) ;;
> -*)
> - shift; shift; shift
> - for ac_arg
> - do $1_os=[$]$1_os-$ac_arg
> - done;;
> + 0|1) set "";;
> + *) shift; shift;;
> esac
This case statement now merely avoids shifting an empty argument list. Given
that this code splits canonical platform names, which have three or more fields,
why not just shift twice, unconditionally?
> +AC_SUBST([$1_os], [$[*]])dnl
> +IFS=$ac_save_IFS
> ])# _AC_CANONICAL_SPLIT
- A simplification of _AC_CANONICAL_SPLIT, Stepan Kasal, 2005/08/16
- Re: A simplification of _AC_CANONICAL_SPLIT,
Noah Misch <=
- Re: A simplification of _AC_CANONICAL_SPLIT, Stepan Kasal, 2005/08/17
- Re: A simplification of _AC_CANONICAL_SPLIT, Noah Misch, 2005/08/17
- Re: A simplification of _AC_CANONICAL_SPLIT, Stepan Kasal, 2005/08/18
- Re: A simplification of _AC_CANONICAL_SPLIT, Paul Eggert, 2005/08/18
- Re: A simplification of _AC_CANONICAL_SPLIT, Stepan Kasal, 2005/08/19
- Re: A simplification of _AC_CANONICAL_SPLIT, Paul Eggert, 2005/08/19
- Re: A simplification of _AC_CANONICAL_SPLIT, Stepan Kasal, 2005/08/22
- Re: A simplification of _AC_CANONICAL_SPLIT, Paul Eggert, 2005/08/22
- Re: A simplification of _AC_CANONICAL_SPLIT, Stepan Kasal, 2005/08/23
- Re: A simplification of _AC_CANONICAL_SPLIT, Paul Eggert, 2005/08/23