autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Make AC_MSG_RESULT_UNQUOTED obsolete


From: Stepan Kasal
Subject: Make AC_MSG_RESULT_UNQUOTED obsolete
Date: Mon, 23 May 2005 18:14:07 +0200
User-agent: Mutt/1.4.1i

Hello,
  I noticed this weird macro: AC_MSG_RESULT_UNQUOTED

It was never documented.  It has a misleading comment that it
does perform ` $ and \ substitutions.  Actually (current version of)
AC_MSG_RESULT does $ and \ substitutions, so the only difference is
that it performs backtick substs, and that you can break it if you
pass a double quote in a parameter.

The macro AC_CACHE_CHECK was the only one in autoconf tree which
used AC_MSG_RESULT_UNQUOTED.  And I think it would be better if it
didn't execute the backticks twice, the following would be better:

ac_res=AS_VAR_GET([$2])
AC_MSG_RESULT([$ac_res])

Actually, everyone should use this pattern instead of
AC_MSG_RESULT_UNQUOTED.  That's why I propose to make it obsolete.

The patch attached to this mail implements this.

Paul, OK to commit?

Stepan

Attachment: autoconf-20050523-res-unq.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]