[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Use expr where possible
|
From: |
Paul Eggert |
|
Subject: |
Re: [PATCH] Use expr where possible |
|
Date: |
Fri, 13 May 2005 16:06:08 -0700 |
|
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/21.4 (gnu/linux) |
Only some very minor comments.
> +[case $ac_file in
> + *:*) _AC_CONFIG_SPLIT(ac_file, ac_file, ac_file_in) ;;
> + - ) ac_file_in=- ;;
> + * ) ac_file_in=$ac_file.in ;;
> +esac[]dnl
The last case should have a tab after the ")" too, to match the others.
Also, the other code omits space before ")" so this probably should too.
> + # No need to use "X$at_option", we know how $at_option looks like.
I'd omit this comment; it's obvious.
Other than that it looks good; thanks. Please install.